[PATCH] D135929: [profile] Add binary ids into indexed profiles

Daniel Thornburgh via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 12 11:54:21 PST 2022


mysterymath added inline comments.


================
Comment at: llvm/lib/ProfileData/InstrProfWriter.cpp:307
+
+  BinaryIds.reserve(IPW.BinaryIds.size());
+  for (auto &I : IPW.BinaryIds)
----------------
Shouldn't this be reserve(BinaryIds.size() + IPW.BinaryIDs.size())?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135929/new/

https://reviews.llvm.org/D135929



More information about the llvm-commits mailing list