[PATCH] D139750: Optionally print symbolizer markup backtraces.

Mon Dec 12 11:43:34 PST 2022

mysterymath added a comment.

In D139750#3986437 <https://reviews.llvm.org/D139750#3986437>, @phosek wrote:

> In D139750#3985896 <https://reviews.llvm.org/D139750#3985896>, @mcgrathr wrote:
>
>> I thought we agreed that the desirable semantics to keep things simple is that if markup is requested then markup is always printed, period. It shouldn't have anything to do with whether llvm-symbolizer works.
>
> I agree, I think it's fine if we keep markup as a fallback in the case when `llvm-symbolizer` fails or is disabled, but there should also be a way to force the use markup without trying anything else.

The idea was to keep LLVM_DISABLE_SYMBOLIZATION and LLVM_ENABLE_SYMBOLIZER_MARKUP orthogonal; it seems prima facie that setting LLVM_ENABLE_SYMBOLIZER_MARKUP shouldn't also have the effect of setting LLVM_DISABLE_SYMBOLIZATION.

But the available options form a priority ordering; at most one method should be used, and some are superior to others. We could reasonable consider the markup workflow to have superior characteristics the others in the scenarios where it applies, so I think it's reasonable for enabling it to implicitly disable the others. Accordingly, I've moved the markup option to the top of the list.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139750/new/

https://reviews.llvm.org/D139750