[PATCH] D139067: [FuzzMutate] New InsertCFGStrategy

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 12 11:04:18 PST 2022


arsenm added inline comments.


================
Comment at: llvm/lib/FuzzMutate/IRMutator.cpp:343-344
+                    }));
+    assert(RS && "I can't find an integer type in all allowed types, is the "
+                 "setting correct?");
+    Type *Ty = RS.getSelection();
----------------
Peter wrote:
> arsenm wrote:
> > assert string is a bit weird
> This is to make sure that when things went wrong, we give some hint to tell the user what's wrong. Is there a recommended way of doing it?
I mean the phrasing with the question, and saying "I"


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139067/new/

https://reviews.llvm.org/D139067



More information about the llvm-commits mailing list