[PATCH] D138864: Setting the LLVM_TARGET_TRIPLE macro based on the LLVM_DEFAULT_TARGET_TRIPLE

Mon Dec 12 11:00:03 PST 2022

daltenty added a comment.

> Sorry, what is the semantic difference between LLVM_DEFAULT_TARGET_TRIPLE and LLVM_TARGET_TRIPLE?

That's a very good question. `LLVM_TARGET_TRIPLE` exists in it's current form due to a rename in  D119918 <https://reviews.llvm.org/D119918>, but `TARGET_TRIPLE` has been set to `LLVM_DEFAULT_TARGET_TRIPLE` going all the way back to rGec2fb226d8b84ee1090f7d7fa2e0da6232fee469 <https://reviews.llvm.org/rGec2fb226d8b84ee1090f7d7fa2e0da6232fee469>. From the usage it looks like we already had `TARGET_TRIPLE` as the internal var we were using in some places, and `LLVM_DEFAULT_TARGET_TRIPLE` was added as
the user configurable option.

I'm not sure there's really a meaningful semantic difference at this point, so perhaps we could unify everything under a single name.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138864/new/

https://reviews.llvm.org/D138864