[PATCH] D139861: [llvm] boilerplate for new callbrprepare codegen IR pass

[Arthur Eubanks via Phabricator via llvm-commits]

aeubanks added inline comments.


================
Comment at: llvm/test/CodeGen/PowerPC/O3-pipeline.ll:87
 ; CHECK-NEXT:       Module Verifier
+; CHECK-NEXT:       Dominator Tree Construction
 ; CHECK-NEXT:       Basic Alias Analysis (stateless AA impl)
----------------
to prevent this you'll want to make sure the pass preserves the domtree, and add
something like [this](https://github.com/llvm/llvm-project/blob/main/llvm/lib/Transforms/Utils/BreakCriticalEdges.cpp)

but if you're not using the domtree right now, you should actually say `setPreservesAll` and later change that to only preserve analyses that you're actually preserving when the pass actually does something


================
Comment at: llvm/tools/opt/opt.cpp:390
       "structurizecfg",       "fix-irreducible",
-      "expand-large-fp-convert"};
+      "expand-large-fp-convert", "callbrprepare",
+  };
----------------
sorry for this, I'm trying to make it so this isn't necessary


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139861/new/

https://reviews.llvm.org/D139861