[PATCH] D138899: [DAGCombiner] handle more store value forwarding

[Roland Froese via Phabricator via llvm-commits]

RolandF added inline comments.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp:17112
+        // Make sure the store is not aliased with any nodes in TokenFactor.
+        GatherAllAliases(Store, Chain, Aliases);
+        if (Aliases.empty() ||
----------------
Is this check really needed for token factor operands? They are supposed to be independent. Aliasing seems like an order dependence.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138899/new/

https://reviews.llvm.org/D138899