[PATCH] D139858: [SCEVExpander] Increase "cheap" expansion budget

Roman Lebedev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 12 09:53:19 PST 2022


lebedev.ri created this revision.
lebedev.ri added reviewers: reames, mkazantsev, nikic, fhahn.
lebedev.ri added a project: LLVM.
Herald added subscribers: javed.absar, zzheng, hiraditya, nemanjai.
Herald added a project: All.
lebedev.ri requested review of this revision.

It is known that having some magical cut-off does just that,
it prevents very large regressions, but is potentially suboptimal
in certain cases.

There has been several reports that the current budget
is just a tad bit too small, and by making SCEV smarter,
e.g. teaching it to handle new IR patterns,
instead of representing them as SCEVUnknown,
makes problem worse.

Let's bump (double) it.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D139858

Files:
  llvm/lib/Transforms/Utils/ScalarEvolutionExpander.cpp
  llvm/test/CodeGen/PowerPC/common-chain.ll
  llvm/test/CodeGen/PowerPC/sms-cpy-1.ll
  llvm/test/Transforms/IndVarSimplify/ARM/indvar-cost.ll
  llvm/test/Transforms/IndVarSimplify/X86/eliminate-trunc.ll
  llvm/test/Transforms/IndVarSimplify/X86/loop-invariant-conditions.ll
  llvm/test/Transforms/IndVarSimplify/exit_value_test2.ll
  llvm/test/Transforms/IndVarSimplify/no-iv-rewrite.ll
  llvm/test/Transforms/IndVarSimplify/post-inc-range.ll
  llvm/test/Transforms/IndVarSimplify/replace-loop-exit-folds.ll
  llvm/test/Transforms/IndVarSimplify/rewrite-loop-exit-values-phi.ll
  llvm/test/Transforms/LoopUnroll/X86/high-cost-expansion.ll
  llvm/test/Transforms/PhaseOrdering/X86/pr38280.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D139858.482179.patch
Type: text/x-patch
Size: 94132 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20221212/dae9dae4/attachment.bin>


More information about the llvm-commits mailing list