[PATCH] D139757: [RISCV] Use reduction result type for EXTRACT_VECTOR_ELT in lowerReductionSeq.
Philip Reames via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Dec 12 09:06:11 PST 2022
reames accepted this revision.
reames added a comment.
This revision is now accepted and ready to land.
LGTM, but with a question to make sure of my understanding.
Are you sure that the interpretation of a reduction with a wider type is as a sext? It needs to be to match the code you're removing, but it could in principle be a zext or aext. Can you point to something in the code to demonstrate it must be sext? Or alternatively, explain why aext is okay?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D139757/new/
https://reviews.llvm.org/D139757
More information about the llvm-commits
mailing list