[PATCH] D139644: [InlineAdvisor] Allow loading advisors as plugins

Mircea Trofin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 12 08:21:11 PST 2022


mtrofin added a comment.

In D139644#3986488 <https://reviews.llvm.org/D139644#3986488>, @IBricchi wrote:

> We will see if @phosek has time, but for context we imitated https://github.com/llvm/llvm-project/blob/main/llvm/unittests/Passes/CMakeLists.txt for the cmake changes.

OK, but why did you need to make everything `LLVM_OPTIONAL_SOURCES` and not just the plugin-loading test?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139644/new/

https://reviews.llvm.org/D139644



More information about the llvm-commits mailing list