[PATCH] D122761: [scudo] Enable more warnings for standalone build

Lei Huang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 12 07:26:12 PST 2022


lei added a comment.

Please note that this patch broke any bots that build this project with `-Werror` (example: https://lab.llvm.org/buildbot/#/builders/19/builds/14037). As a result, I have reverted it since there has been no fix within a reasonable time.
May I advise ensuring that a project is clean wrt. to the additional warnings when turning on extra warnings as there are bound to be some builds that use `-Werror`. Also, new warnings are almost always disruptive changes as there are many different build configurations that may be affected in unforeseen ways. If you have such a disruptive change ready to commit, it is advisable to wait until Monday to commit it rather than committing it on a Friday evening just as everyone is disconnecting for the weekend.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122761/new/

https://reviews.llvm.org/D122761



More information about the llvm-commits mailing list