[PATCH] D139408: [InstCombine] Fold logic-and/logic-or by distributive laws

chenglin.bi via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 12 04:23:43 PST 2022


bcl5980 added a comment.

In D139408#3987800 <https://reviews.llvm.org/D139408#3987800>, @nikic wrote:

> Did this get subsumed by https://github.com/llvm/llvm-project/commit/9ddff66d0c9c3e18d56e6b20aa26a2a8cdfb6d2b?

I rebase the code. 
I think rG9ddff66d0c9c3e18d56e6b20aa26a2a8cdfb6d2b <https://reviews.llvm.org/rG9ddff66d0c9c3e18d56e6b20aa26a2a8cdfb6d2b> can cover part of this path. And it can't cover some cases like:

  @logic_and_logic_or_3
  @logic_and_logic_or_4
  @logic_and_logic_or_6
  @logic_and_logic_or_7

If any of you think this is redundant I can abandon it.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139408/new/

https://reviews.llvm.org/D139408



More information about the llvm-commits mailing list