[PATCH] D139797: [exegesis] Benchmark: provide optional progress meter / ETA
Clement Courbet via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Dec 12 03:54:42 PST 2022
courbet added inline comments.
================
Comment at: llvm/unittests/tools/llvm-exegesis/ProgressMeterTest.cpp:24
+
+ // static constexpr bool is_steady = true;
+
----------------
?
================
Comment at: llvm/unittests/tools/llvm-exegesis/ProgressMeterTest.cpp:30
+static int CurrentTimePoint = 0;
+auto Pt = [](int i) {
+ return PreprogrammedClock::time_point(PreprogrammedClock::duration(i));
----------------
[nit] at top level, I this this would be better as a function rather than a variable of lambda type:
```
auto Pt(int i) {return PreprogrammedClock::time_point(PreprogrammedClock::duration(i)); }
```
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D139797/new/
https://reviews.llvm.org/D139797
More information about the llvm-commits
mailing list