[PATCH] D137368: [lld-macho] Overhaul map file code

[Vincent Lee via Phabricator via llvm-commits]

thevinster added a comment.

In D137368#3916144 <https://reviews.llvm.org/D137368#3916144>, @thakis wrote:

> In D137368#3915933 <https://reviews.llvm.org/D137368#3915933>, @int3 wrote:
>
>>> Does this allow us to undo D115416 <https://reviews.llvm.org/D115416>?
>>
>> Possibly, I'll have to do some benchmarks. However I think it is likely still a performance improvement to do it in parallel
>
> Sure, but having simpler code makes it easier to parallelize other parts. Doing complicated parallelism too early makes it harder to do parallelize things that would otherwise be easier to parallelize and might get us stuck in a local optimum.
>
> (This is admittedly very hand-wavy!)

@thakis the benchmarks on my end (especially on larger builds) bottleneck on writing map files than the binary writing stage, so this would be a regression on our end if D115416 <https://reviews.llvm.org/D115416> is reverted. I do think we can find a happy medium where code is more extendable and keep the behavior parallelizing the map file stage. But before making any sudden moves, it would be nice to know what other general parallelization improvements you are thinking of so we can align on the correct path forward.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137368/new/

https://reviews.llvm.org/D137368