[PATCH] D139797: [exegesis] Benchmark: provide optional progress meter / ETA
Simon Pilgrim via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Dec 12 02:27:53 PST 2022
RKSimon added a comment.
In D139797#3987258 <https://reviews.llvm.org/D139797#3987258>, @lebedev.ri wrote:
> In D139797#3987231 <https://reviews.llvm.org/D139797#3987231>, @tschuett wrote:
>
>> Did find you found this one:
>> https://reviews.llvm.org/D38416
>
> I'm wary of patch feature creep and *exceptionally* wary of review sluggishness.
> I don't think we are not allowed to add something to a subtool even it it would fit into elsewhere.
Agreed - better to keep this inside exegesis until someone actually needs it someplace else - as long as the only exegesis dependency is the namespace it should be easier enough to move to Support (and change the namespace then),
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D139797/new/
https://reviews.llvm.org/D139797
More information about the llvm-commits
mailing list