[PATCH] D139683: [APInt] provide a safe API for zext value and sext value.

[Thorsten via Phabricator via llvm-commits]

tschuett added inline comments.


================
Comment at: llvm/include/llvm/ADT/APInt.h:1501
+    return (getActiveBits() <= 64) ? std::optional<uint64_t>(getZExtValue())
+                                   : std::optional<uint64_t>();
+  };
----------------
RKSimon wrote:
> tschuett wrote:
> > `std::nullopt`?
> +1
`std::optional<uint64_t>(std::nullopt)`.  --> `std::nullopt` .

`std::optional<uint64_t>(getZExtValue())` ->. `getZExtValue()`.



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139683/new/

https://reviews.llvm.org/D139683