[PATCH] D136432: [AMDGPU] Combine BFI instructions.

[Thomas Symalla via Phabricator via llvm-commits]

tsymalla added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUISelDAGToDAG.cpp:2175-2178
+  struct BFIOperandData {
+    SDNode *Or;
+    MaskData Mask;
+  };
----------------
nhaehnle wrote:
> You don't really need the `Or` in here. (It's only used to get the value type, but why -- you know that this only works with MVT::i32)
That is not entirely correct. It is also used to retrieve the original SDLoc of the (nested) Or. So I think it can stay. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136432/new/

https://reviews.llvm.org/D136432