[PATCH] D139616: [TableGen] Emit table mapping physical registers to base classes

[Jay Foad via Phabricator via llvm-commits]

foad added inline comments.


================
Comment at: llvm/utils/TableGen/RegisterInfoEmitter.cpp:1612
+      // Represent class indexes with uint8_t and allocate one index for nullptr
+      assert(BaseClasses.size() < UINT8_MAX && "Too many base register classes");
+
----------------
This is still off by one. UINT8_MAX is 255 not 256.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139616/new/

https://reviews.llvm.org/D139616