[PATCH] D139682: [DAG] Stop replace masked compressstore with normal masked store

[Xiang Zhang via Phabricator via llvm-commits]

xiangzhangllvm added inline comments.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp:11034
   // truncating store.  We can do this even if this is already a masked
-  // truncstore.
+  // truncstore or a compress store.
   if ((Value.getOpcode() == ISD::TRUNCATE) && Value->hasOneUse() &&
----------------
pengfei wrote:
> pengfei wrote:
> > xiangzhangllvm wrote:
> > > pengfei wrote:
> > > > Do you mean cannot be a compress store?
> > > Yes, right
> > Don't forget update the comments.
> I meant the comment `We can do this even if this is already a masked truncstore or a compress store` is wrong. I'd expect it would be:
> ```
>   // If this is a TRUNC followed by a masked store, fold this into a masked
>   // truncating store.  We can do this even if this is already a masked
>   // truncstore.
>   // If this is a TRUNC followed by a compress store, we don't do the combine.
>   // TODO: Try combine to masked compress store if possiable.
> ```
Good catch! Done in 7557d94bd8d92e486084074e1017eb33149f9156 , thanks again!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139682/new/

https://reviews.llvm.org/D139682