[PATCH] D138910: [RS4GC] Turn lambda into static function. NFC.

Serguei Katkov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Dec 11 19:20:41 PST 2022


skatkov added a comment.

If I read it correctly the only change you did while copying is handling reverse order. So lgtm.

You can consider split it into two NFC parts. The first one is handling reverse, the second one is just extract. It would be a bit easier to review.

BTW, now with you change, do we really need to copy Record.ChainToBase to ChainToBase?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138910/new/

https://reviews.llvm.org/D138910



More information about the llvm-commits mailing list