[PATCH] D107352: [MemoryLocation] learn about ptr_provenance

[Jeroen Dobbelaere via Phabricator via llvm-commits]

jeroen.dobbelaere added a comment.

In D107352#3986784 <https://reviews.llvm.org/D107352#3986784>, @jeroen.dobbelaere wrote:

> In D107352#3957589 <https://reviews.llvm.org/D107352#3957589>, @asbirlea wrote:
>
>> Could you add updated compile-time impact measurements after the latest rebase?
>
> I have rebased the patches and let the compile-time tracker look at it. Results can be found here:  https://llvm-compile-time-tracker.com/?config=NewPM-O3&stat=instructions%3Au&remote=dobbelaj-snps&branch=dobbelaj-snps/perf/ptr_provenance-20221207-02
> Compared to the (old) run with the huge effect on the speed, there is still some effect visible. (1e51b7f42b)

https://llvm-compile-time-tracker.com/?config=NewPM-O3&stat=instructions%3Au&remote=dobbelaj-snps&branch=dobbelaj-snps/perf/MemoryLocation-hashing-20221211-01 shows that most of the regression originates from using `llvm::hash_combine` instead of  `operator^` (fadd01d66c).  A smaller part is added because of the memory usage and initialization of the extra pointer member.  Including that extra pointer into the hash computation seems to have only minimal effect.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107352/new/

https://reviews.llvm.org/D107352