[PATCH] D139761: Verifier: Enforce value of llvm.is.fpclass test mask

[James Y Knight via Phabricator via llvm-commits]

jyknight accepted this revision.
jyknight added inline comments.
This revision is now accepted and ready to land.


================
Comment at: llvm/lib/IR/Verifier.cpp:5016
+    Check((TestMask->getZExtValue() & ~fcAllFlags) == 0,
+          "llvm.is.fpclass test mask only has 10 bits");
+    break;
----------------
I might avoid saying "has 10 bits" in the error string since that seems likely to forget to be updated. Maybe something like "Unsupported bits passed to llvm.is.fpclass test mask."? (Just choose something and commit.)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139761/new/

https://reviews.llvm.org/D139761