[PATCH] D135202: [IR] Add an opaque type to LLVM.

[Nikita Popov via Phabricator via llvm-commits]

nikic accepted this revision.
nikic added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: llvm/docs/LangRef.rst:3628
+``undef``, and ``poison``. Other possible values for target extension types may
+arise from target-specific intrinsics and functions.
+
----------------
Possibly this should clarify that not all target extension types can have zeroinitializer.


================
Comment at: llvm/test/Assembler/target-type-properties.ll:2
+; RUN: sed -e 's/;T1://' %s | not llvm-as -o /dev/null 2>&1 | FileCheck --check-prefix=CHECK-T1 %s
+; RUN: sed -e 's/;T2://' %s | not llvm-as -o /dev/null 2>&1 | FileCheck --check-prefix=CHECK-T2 %s
+; Check target extension type properties are verified in the assembler.
----------------
This is pretty weird, use `split-file` instead?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135202/new/

https://reviews.llvm.org/D135202