[PATCH] D139764: [COFF] Respect weak externals for mangled symbol searching

Shoaib Meenai via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Dec 9 20:17:27 PST 2022


smeenai created this revision.
smeenai added reviewers: compnerd, hans, mstorsjo, rnk, yozhu.
Herald added a project: All.
smeenai requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

We were previously ignoring weak aliases during these searches (which
are used for the entry point, exports, and subsystem inference), which
differed from link.exe behavior. It also meant that we could get
different behavior when linking an object file directly vs. packaging it
into a static library, because static library symbol name directories
include weak externals.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D139764

Files:
  lld/COFF/SymbolTable.cpp
  lld/test/COFF/entry-weak-external.s
  lld/test/COFF/subsystem-inference-weak-external.s

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D139764.481820.patch
Type: text/x-patch
Size: 3976 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20221210/a974102d/attachment.bin>


More information about the llvm-commits mailing list