[PATCH] D139706: [RISCV][VP] expand vp intrinscs if no +v feature

[Yingchi Long via Phabricator via llvm-commits]

inclyc added inline comments.


================
Comment at: llvm/lib/Target/RISCV/RISCVTargetTransformInfo.h:245
     using VPLegalization = TargetTransformInfo::VPLegalization;
+    if (!ST->hasStdExtV())
+      return VPLegalization(VPLegalization::Discard, VPLegalization::Convert);
----------------
craig.topper wrote:
> craig.topper wrote:
> > craig.topper wrote:
> > > What if the target has Zve*?
> > This should be hasInstructionsV
> Oops I meant `hasVInstructions()`
I'm curious about if we need a switch-case statement here to check what exactly features do a vp.* need. e.g. Some intrinsics may require F/D extension (Zve*f/Zve*d) and others may not.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139706/new/

https://reviews.llvm.org/D139706