[PATCH] D132908: [RISCV][COST] Add half type support for the cost model of sqrt/fabs

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Dec 9 18:06:14 PST 2022


craig.topper added inline comments.


================
Comment at: llvm/lib/Target/RISCV/RISCVTargetTransformInfo.cpp:445
+    auto LT = getTypeLegalizationCost(RetTy);
+    if ((ST->hasVInstructions() || ST->hasVInstructionsF16()) &&
+        LT.second.isVector())
----------------
ST->hasVInstructionF16() is only true if hasVInstructions() is true so this || doesn't do anything.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132908/new/

https://reviews.llvm.org/D132908



More information about the llvm-commits mailing list