[PATCH] D139467: AMDGPU: Add AMDGPUSubtarget::getEUsPerCU()

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUSubtarget.h:213
 
+  // Number of SIMDs per "CU", where the "CU" is the unit onto which workgroups
+  // are mapped. This takes WGP mode vs. CU mode into account.
----------------
foad wrote:
> nhaehnle wrote:
> > foad wrote:
> > > Since "CU" is misleading, can you think of a better name for "unit onto which workgroups are mapped"?
> > I was wondering this as well and am open to suggestions.
> > 
> > Work Group Processor obviously doesn't work.
> > 
> > Work Group Compute Unit (WGCU)? Work Group Unit (WGU)? Work Group Execution Unit (WGEU)? (And make the EU a Wave Execution Unit?)
> It's a shame there isn't an existing term. Your ideas sound OK to me, but none of them is so obviously great that we should immediately adopt it (IMO).
Should include the expanded forms of these acronyms in the comments. Also /// for doxygen I think?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139467/new/

https://reviews.llvm.org/D139467