[PATCH] D139227: [AMDGPU] Update MFMASmallGemmOpt with better performing stategy

Austin Kerbow via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Dec 9 14:02:30 PST 2022


kerbowa added a comment.

In D139227#3980133 <https://reviews.llvm.org/D139227#3980133>, @jrbyrnes wrote:

> Hi Austin,
>
> Changes look fine -- and if experiments show it has better performance then I suppose it is better. But the pipeline seems rather arbitrary -- in fact, in the test the previous pipeline fits the requirements of the new one. Maybe since the DAG is less constrained the scheduler has a better ability to produce improved schedule?
>
> Also, having pipeline with 3x as many MFMA SchedGroups as there are MFMAs is an impossible pipeline. I assume you also tried ` I < MFMACount ` ?

Matching specific pipelines is difficult and often doesn't correlate super well with the requested pipeline. We need to rely on what experimentally gives the best results for now. This will change again in the future.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139227/new/

https://reviews.llvm.org/D139227



More information about the llvm-commits mailing list