[PATCH] D139316: ValueTracking: Teach isKnownNeverInfinity about rounding intrinsics

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Dec 9 13:35:12 PST 2022


arsenm added a subscriber: nemanjai.
arsenm added a comment.

In D139316#3984809 <https://reviews.llvm.org/D139316#3984809>, @arsenm wrote:

> In D139316#3982777 <https://reviews.llvm.org/D139316#3982777>, @jcranmer-intel wrote:
>
>> In D139316#3981280 <https://reviews.llvm.org/D139316#3981280>, @kpn wrote:
>>
>>> Are we certain that a value that is very close to infinity won't trip over into infinity after rounding?
>>
>> I'm thinking it might not be true for ppc_fp128--{largest_finite64, 0.75} should round into infinity I think? All of the other IEEE-like floating point types should have it be true, though--even e4m3 and e5m2 have largest_finite be an integer.
>
> What should I do here? How do I check this? godbolt seems to not support ppc execution, and I've had a real hard time finding any ppc f128 documentation

cc @nemanjai What is the ppcf128 behavior for these functions?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139316/new/

https://reviews.llvm.org/D139316



More information about the llvm-commits mailing list