[PATCH] D139673: [AMDGPU][SIFrameLowering] Mark VGPR used for AGPR spills as reserved

Jeffrey Byrnes via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Dec 9 12:42:34 PST 2022


jrbyrnes added a comment.

In D139673#3982757 <https://reviews.llvm.org/D139673#3982757>, @arsenm wrote:

> We should work towards eliminating the special case handling of "spilling" between AGPRs and VGPRs. The allocator now knows they have a common allocatable class and introduces new vregs and copies as needed. We only still have this special handling because it breaks an optimization that works by accident now (which is unused subregister related)

This is something I can explore after this patch -- for now there is an ask to resolve this into 5.5 so I think we will need this patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139673/new/

https://reviews.llvm.org/D139673



More information about the llvm-commits mailing list