[PATCH] D127812: [AArch64] FMV support and necessary target features dependencies.

[Daniel Kiss via Phabricator via llvm-commits]

danielkiss accepted this revision.
danielkiss added a comment.
This revision is now accepted and ready to land.

just small comment, thanks @ilinpv
LGTM, just let others to chime in.



================
Comment at: clang/lib/Basic/Targets/AArch64.cpp:652
+  // AARCH64_ARCH_EXT_NAME feature with top priority must be taken.
+  return multiVersionSortPriority("sme2");
+}
----------------
wondering if we could use `FEAT_MAX` (or similar) here to avoid error as add features later. maybe a comment in `AArch64TargetParser.def` is the solution.


================
Comment at: clang/lib/Basic/Targets/AArch64.cpp:771-790
+  HasRDM = false;
+  HasDIT = false;
+  HasCCPP = false;
+  HasCCDP = false;
+  HasFRInt3264 = false;
+  HasFlagM = false;
+  HasAlternativeNZCV = false;
----------------
Please note the initialisation moved, see D139622. 
Sorry , but hopefully an easy rebase.


================
Comment at: clang/lib/Basic/Targets/AArch64.cpp:1010-1011
+
+  if (HasNoNeon)
+    FPU &= ~NeonMode;
+  if (HasNoSVE)
----------------
maybe we need do disable SVE too here?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127812/new/

https://reviews.llvm.org/D127812