[PATCH] D138496: [OMPIRBuilder] Add OpenMPDefaultSimdAlignment field to TargetMachine class

[Johannes Doerfert via Phabricator via llvm-commits]

jdoerfert added a comment.

In D138496#3984775 <https://reviews.llvm.org/D138496#3984775>, @domada wrote:

> I think we cannot not rely on DataLayout to find the maximal SIMD alignment.
>
> Developer can specify that given functions are targeted to different subtargets (source: https://clang.llvm.org/docs/AttributeReference.html#target ). That's why information about target subtype is stored in function attribute not in the data layout string which is common for the whole Module.

The subtarget can only "improve" our information, right? We need to involve the target, provide it with the type, the datalayout, and the function attributes to make a decision. No?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138496/new/

https://reviews.llvm.org/D138496