[PATCH] D139719: [BasicAA] Remove support for PhiValues analysis

Johannes Doerfert via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Dec 9 10:06:22 PST 2022


jdoerfert added a comment.

Seems reasonable to me.



================
Comment at: llvm/lib/Analysis/BasicAliasAnalysis.cpp:1359
-    // If we don't have PhiInfo then just look at the operands of the phi itself
-    // FIXME: Remove this once we can guarantee that we have PhiInfo always
-    SmallPtrSet<Value *, 4> UniqueSrc;
----------------
FWIW, this was added 4years ago via https://reviews.llvm.org/D44564. It's safe to say we didn't move towards enabling it all the time.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139719/new/

https://reviews.llvm.org/D139719



More information about the llvm-commits mailing list