[PATCH] D137837: [Support] Move Target/CPU Printing out of CommandLine

Fri Dec 9 09:48:36 PST 2022

fpetrogalli added a comment.

In D137837#3976344 <https://reviews.llvm.org/D137837#3976344>, @MaskRay wrote:

> I think this patch can drop `cl::AddExtraVersionPrinter(sys::printDefaultTargetAndDetectedCPU);` from most tools. Only add them case by case when there is consensus there is a significant value.

@MaskRay / @lenary can we consider this clean up operation a separate piece of work and move on with the patch-set submission needed to get D137838 <https://reviews.llvm.org/D137838> in?

We all agreed that the work leading at D137838 <https://reviews.llvm.org/D137838> is a better solution than D137516 <https://reviews.llvm.org/D137516> because it is breaking the `tblgen` / `libSupport` dependency for all targets. I am really thankful that @lenary offered their time to work on this. 
The fact that we are getting so little attention from other members is maybe is a sign that we can just move on and merge it without waiting for more consensus? If anything turn out to be wrong, we can always fix up/revert?

Thank you!

Francesco

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137837/new/

https://reviews.llvm.org/D137837