[PATCH] D136335: [Assignment Tracking Analysis][5/*] Tests

[Jeremy Morse via Phabricator via llvm-commits]

jmorse accepted this revision.
jmorse added a comment.
This revision is now accepted and ready to land.

I had another chat with Orlando about how we're testing these patches -- I'm pretty happy that we're now testing all the important paths through the assignment-tracking analysis pass, and the different ways that CFGs can compose and have different lattice input/output values. Nothing really springs to mind about what else we can be testing -- and significantly, this work is not going to be enabled by default, we'll be doing a decent amount of validating on larger projects first.

With that in mind, LGTM to land. I anticipate that validation is going to find other bugs in this pass, but we're past the point of more guessing-at-what-to-test being a good return on investment....

> Another bug was found when writing that new test which I will patch shortly. All of these bugs have been to do with fragment handling (unsurprisingly).

Assuming this is now fixed!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136335/new/

https://reviews.llvm.org/D136335