[PATCH] D139625: [mlir][SparseTensor] Add a few tests for sparse vectorization

[Quentin Colombet via Phabricator via llvm-commits]

qcolombet marked 2 inline comments as done.
qcolombet added inline comments.


================
Comment at: mlir/test/Dialect/SparseTensor/vectorize_reduction.mlir:2
+// RUN: mlir-opt %s -sparsification -cse -sparse-vectorization="vl=8" -cse -split-input-file | \
+// RUN:   FileCheck %s --check-prefix=ON
+// RUN: mlir-opt %s -sparsification -cse -split-input-file | \
----------------
aartbik wrote:
> can we make this CHECK-ON/CHECK-OFF to make it more consistent with style in this dir?
Sure thing!


================
Comment at: mlir/test/Dialect/SparseTensor/vectorize_reduction.mlir:363
+
+// Check that wer vectorize reduction with subi.
+//
----------------
aartbik wrote:
> wer -> we
Good catch


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139625/new/

https://reviews.llvm.org/D139625