[PATCH] D139254: Enhance stack protector

[Xiang Zhang via Phabricator via llvm-commits]

xiangzhangllvm added inline comments.


================
Comment at: llvm/lib/CodeGen/StackProtector.cpp:582
+        if (RecalculateDT) {
+          DT->recalculate(*F);
+        } else {
----------------
xiangzhangllvm wrote:
> LuoYuanke wrote:
> > This should increase compiling time. Need refine it by moving the BB child to NewBB.
> Yes, ok, let me add more code here, first delete the related old DT Edges and add back to the new ones.
Let me first move the DT->recalculate out of loop.
I try do more faster update for the change, but meet some problems. 
I need time to deeply look into the dominator tree.
Pls let me first fix the problem self and then do optimization.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139254/new/

https://reviews.llvm.org/D139254