[PATCH] D138923: AMDGPU: Erase llvm.global_ctors/global_dtors after lowering

[Sameer Sahasrabuddhe via Phabricator via llvm-commits]

sameerds added inline comments.


================
Comment at: llvm/test/CodeGen/AMDGPU/lower-ctor-dtor.ll:6
+; RUN: opt -S -mtriple=amdgcn-- -passes=amdgpu-lower-ctor-dtor,amdgpu-lower-ctor-dtor < %s | FileCheck %s
 ; RUN: llc -mtriple=amdgcn-amd-amdhsa -mcpu=gfx700 -filetype=obj -o - < %s | llvm-readelf -s - 2>&1 | FileCheck %s -check-prefix=CHECK-VIS
 
----------------
Using "CHECK-" as a prefix for a custom check prefix is a bit confusing. Why not just use something clearly distinct, like "ISA"?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138923/new/

https://reviews.llvm.org/D138923