[PATCH] D139414: [RISCV] Emit .variant_cc directives for vector function calls.

Jessica Clarke via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Dec 9 00:56:33 PST 2022


jrtc27 added inline comments.


================
Comment at: llvm/lib/Target/RISCV/RISCVAsmPrinter.cpp:233
+  const auto *RMFI = MF->getInfo<RISCVMachineFunctionInfo>();
+  if (RMFI->isVectorCall()) {
+    auto &RTS =
----------------
smd wrote:
> Hi,
> Could this label printing be extended not only for vector calls, but also for functions that has variant_cc flag set?
> I guess this is what I need for D132994 to go further.
> Thanks
Your code should just be calling emitDirectiveVariantCC, not poking around in the symbol directly. Emitting the directive based on st_other is backwards.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139414/new/

https://reviews.llvm.org/D139414



More information about the llvm-commits mailing list