[PATCH] D139627: clang/X86: Don't emit "min-legal-vector-width"="0"

[Phoebe Wang via Phabricator via llvm-commits]

pengfei added a comment.

In D139627#3982387 <https://reviews.llvm.org/D139627#3982387>, @arsenm wrote:

> In D139627#3982385 <https://reviews.llvm.org/D139627#3982385>, @arsenm wrote:
>
>>> [1] `"min-legal-vector-width" = "0"` was clear to indicate there are only scalar operations.
>>
>> It's not remotely clear what this means
>
> It also doesn't mean that, because the IR doesn't have to be consistent with the attribute. The IR exists independent of the attribute, and the attribute can only provide performance hints.

I don't agree. There are attributes like `zeroext`, `byref` are ABI related see https://llvm.org/docs/LangRef.html#parameter-attributes. I'd take `min-legal-vector-width` as a similar one.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139627/new/

https://reviews.llvm.org/D139627