[PATCH] D138986: [AIX][BigArchive] Treat the archive is empty if the first child member offset is zero

Kai Luo via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Dec 9 00:52:36 PST 2022


lkail marked an inline comment as done.
lkail added inline comments.


================
Comment at: llvm/include/llvm/Object/Archive.h:418
+    return Data.getBufferSize() == sizeof(FixLenHdr) ||
+           getFirstChildOffset() == 0;
   };
----------------
Esme wrote:
> Can we remove the check of `Data.getBufferSize() == sizeof(FixLenHdr)`? I think `getFirstChildOffset() == 0` can cover that case.
Good point, it looks reasonable.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138986/new/

https://reviews.llvm.org/D138986



More information about the llvm-commits mailing list