[PATCH] D139692: [IndVars] Use symbolic max block exit count to handle the last iter

[Nikita Popov via Phabricator via llvm-commits]

nikic added a comment.

The change looks fine, but I think the naming here is now a mess. We have ExitCount (the exact exit count of this exit), SymbolicMaxExitCount (the max exit count of this exit) and MaxExitCount (the max backedge taken count). I'd suggest to rename these variables as follows:

  MaxExitCount -> MaxBECount
  ExitCount -> ExactExitCount
  SymbolicMaxExitCount -> MaxExitCount

Or keep including Symbolic if you think it adds value. (Preferably precommit the rename.)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139692/new/

https://reviews.llvm.org/D139692