[PATCH] D139645: [WebAssembly] Fold adds with global addresses into load offset

Derek Schuff via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Dec 8 17:29:02 PST 2022


dschuff added inline comments.


================
Comment at: llvm/test/CodeGen/WebAssembly/userstack.ll:336
+; global address, so we should fold the global address into the offset, but not
+; the frame offset.
 ; CHECK-LABEL: frame_offset_with_global_address
----------------
so the result of this is that the frame offset will end up in a const or add expression (consumed by the i32.load8_u), and the global address will be folded?
Is this better than what we did before (i.e. the address in a const and the frame offset folded)?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139645/new/

https://reviews.llvm.org/D139645



More information about the llvm-commits mailing list