[PATCH] D139679: [X86] Don't zero out %eax if both %al and %ah are used
Matt Arsenault via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Dec 8 15:59:05 PST 2022
arsenm added inline comments.
================
Comment at: llvm/lib/Target/X86/X86FrameLowering.cpp:499-501
void X86FrameLowering::emitZeroCallUsedRegs(BitVector RegsToZero,
MachineBasicBlock &MBB) const {
const MachineFunction &MF = *MBB.getParent();
----------------
Why is this doing so much work? Why can't this use LivePhysRegUnits and addLiveOuts?
================
Comment at: llvm/lib/Target/X86/X86FrameLowering.cpp:535
+ for (const auto &MO : MI.operands()) {
+ if (!MO.isReg())
+ continue;
----------------
Not checking for a def?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D139679/new/
https://reviews.llvm.org/D139679
More information about the llvm-commits
mailing list