[PATCH] D139675: [WebAssembly] Nullify dangling register DBG_VALUEs

[Derek Schuff via Phabricator via llvm-commits]

dschuff accepted this revision.
dschuff added inline comments.
This revision is now accepted and ready to land.


================
Comment at: llvm/lib/Target/WebAssembly/WebAssemblyDebugFixup.cpp:68
+// associated with the variable, which will appear as "optimized out".
+static void nullifyDanglingDebugValues(MachineFunction &MF,
+                                       const TargetInstrInfo *TII) {
----------------
If we made this function take the MBB as an arg instead of the MF, we could call it at the end of the main for-loop in `runOnMachineFunction`. This would mean that we would iterate over each MBB right after having previously iterated over it, (instead of making 2 passes over the whole function), and result in improved locality for functions which are larger than the CPU data cache.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139675/new/

https://reviews.llvm.org/D139675