[PATCH] D139673: [AMDGPU][SIFrameLowering] Mark VGPR used for AGPR spills as reserved

Stanislav Mekhanoshin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Dec 8 13:32:13 PST 2022


rampitec added a comment.

In D139673#3982757 <https://reviews.llvm.org/D139673#3982757>, @arsenm wrote:

> We should work towards eliminating the special case handling of "spilling" between AGPRs and VGPRs. The allocator now knows they have a common allocatable class and introduces new vregs and copies as needed. We only still have this special handling because it breaks an optimization that works by accident now (which is unused subregister related)

The special handling is not about unused subregs. It is to allow not to spill the whole wide register into memory if there are free registers.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139673/new/

https://reviews.llvm.org/D139673



More information about the llvm-commits mailing list