[PATCH] D139639: Attributes: Add function getter to parse integer string attributes

Arthur Eubanks via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Dec 8 11:13:35 PST 2022


aeubanks added inline comments.


================
Comment at: llvm/lib/IR/Function.cpp:670
+    if (Str.getAsInteger(0, Result))
+      getContext().emitError("cannot parse integer attribute " + Name);
+  }
----------------
arsenm wrote:
> aeubanks wrote:
> > having the attribute name in the error would be helpful
> It is, did you mean the function name?
sorry, I meant `Str`, but function name would also be helpful


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139639/new/

https://reviews.llvm.org/D139639



More information about the llvm-commits mailing list