[PATCH] D139639: Attributes: Add function getter to parse integer string attributes

[Arthur Eubanks via Phabricator via llvm-commits]

aeubanks accepted this revision.
aeubanks added a comment.

lg with one nit



================
Comment at: llvm/lib/IR/Function.cpp:670
+    if (Str.getAsInteger(0, Result))
+      getContext().emitError("cannot parse integer attribute " + Name);
+  }
----------------
having the attribute name in the error would be helpful


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139639/new/

https://reviews.llvm.org/D139639