[PATCH] D139647: [opt] Disincentivize new tests from using old pass syntax

Thu Dec 8 09:52:20 PST 2022

lebedev.ri created this revision.
lebedev.ri added a reviewer: aeubanks.
lebedev.ri added a project: LLVM.
Herald added subscribers: kosarev, mattd, gchakrabarti, asavonic, jeroen.dobbelaere, ormris, jdoerfert, kerbowa, pengfei, dmgreen, asbirlea, steven_wu, zzheng, kbarton, hiraditya, arichardson, jvesely, nemanjai.
Herald added a reviewer: kmitropoulou.
Herald added a project: All.
lebedev.ri requested review of this revision.
Herald added subscribers: pcwang-thead, jholewinski.

The past day or so, i've took a large swing at our tests,
and reduced the number of tests that were still using the old syntax
from ~1800 to just 200.

Left to handle: (as it is seen in this patch)

- Transforms/LSR
- Transforms/CGP
- Transforms/TypePromotion
- Transforms/HardwareLoops
- Analysis/*
- some misc.

I think this is the right point to start actively refusing
to honor the old syntax, except for the old tests,
to prevent the old syntax from creeping back in.

Thus, let's add temporary default-off flag,
and if it is not passed refuse to accept old syntax.
The tests that still need porting are annotated with this flag.

Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D139647

Files:
  llvm/test/Analysis/AliasSet/unknown-inst-tracking.ll
  llvm/test/Analysis/CallGraph/2008-09-09-DirectCall.ll
  llvm/test/Analysis/CallGraph/2008-09-09-UsedByGlobal.ll
  llvm/test/Analysis/CallGraph/callback-calls.ll
  llvm/test/Analysis/CallGraph/ignore-assumelike-calls.ll
  llvm/test/Analysis/CallGraph/ignore-callback-uses.ll
  llvm/test/Analysis/CallGraph/llvm-used.ll
  llvm/test/Analysis/CallGraph/no-intrinsics.ll
  llvm/test/Analysis/CallGraph/non-leaf-intrinsics.ll
  llvm/test/Analysis/Dominators/2007-07-11-SplitBlock.ll
  llvm/test/Analysis/Dominators/2007-07-12-SplitBlock.ll
  llvm/test/Analysis/Dominators/invoke.ll
  llvm/test/Analysis/GlobalsModRef/pr12351.ll
  llvm/test/Analysis/LazyValueAnalysis/lvi-after-jumpthreading.ll
  llvm/test/Analysis/LazyValueAnalysis/lvi-for-ashr.ll
  llvm/test/Analysis/LoopAccessAnalysis/interleave-innermost.ll
  llvm/test/Analysis/LoopAccessAnalysis/memcheck-ni.ll
  llvm/test/Analysis/LoopAccessAnalysis/scalable-vector-regression-tests.ll
  llvm/test/Analysis/MemorySSA/debugvalue.ll
  llvm/test/Analysis/MemorySSA/loop-rotate-inv-template.ll
  llvm/test/Analysis/MemorySSA/loop-rotate-simplified-clone.ll
  llvm/test/Analysis/MemorySSA/loop-rotate-valuemap.ll
  llvm/test/Analysis/MemorySSA/loop-unswitch.ll
  llvm/test/Analysis/MemorySSA/nondeterminism.ll
  llvm/test/Analysis/MemorySSA/pr40037.ll
  llvm/test/Analysis/MemorySSA/pr40749_2.ll
  llvm/test/Analysis/MemorySSA/pr42294.ll
  llvm/test/Analysis/MemorySSA/pr43044.ll
  llvm/test/Analysis/MemorySSA/pr43641.ll
  llvm/test/Analysis/MemorySSA/pr44029.ll
  llvm/test/Analysis/MemorySSA/pr46574.ll
  llvm/test/Analysis/MemorySSA/simple_loop_unswitch_nontrivial.ll
  llvm/test/Analysis/MustExecute/const-cond.ll
  llvm/test/Analysis/MustExecute/infinite_loops.ll
  llvm/test/Analysis/MustExecute/loop-header.ll
  llvm/test/Analysis/MustExecute/pr57780.ll
  llvm/test/Analysis/ScalarEvolution/2007-08-06-MisinterpretBranch.ll
  llvm/test/Analysis/ScalarEvolution/2012-03-26-LoadConstant.ll
  llvm/test/Analysis/ScalarEvolution/2012-05-29-MulAddRec.ll
  llvm/test/Analysis/ScalarEvolution/avoid-assume-hang.ll
  llvm/test/Analysis/ScalarEvolution/scev-expander-existing-value-offset.ll
  llvm/test/Analysis/ScalarEvolution/scev-expander-reuse-unroll.ll
  llvm/test/Analysis/ScalarEvolution/scev-expander-reuse-vect.ll
  llvm/test/Analysis/ScalarEvolution/scev-invalid.ll
  llvm/test/Bitcode/compatibility-6.0.ll
  llvm/test/Bitcode/extractelement.ll
  llvm/test/Bitcode/infer_dso_local.ll
  llvm/test/CodeGen/AArch64/llvm-masked-gather-legal-for-sve.ll
  llvm/test/CodeGen/AArch64/llvm-masked-scatter-legal-for-sve.ll
  llvm/test/CodeGen/AArch64/sve-ptest-removal-cmple.ll
  llvm/test/CodeGen/AMDGPU/amdgpu-unroll-threshold.ll
  llvm/test/CodeGen/AMDGPU/force-alwaysinline-lds-global-address.ll
  llvm/test/CodeGen/AMDGPU/inline-maxbb.ll
  llvm/test/CodeGen/AMDGPU/loop-idiom.ll
  llvm/test/CodeGen/AMDGPU/opencl-printf-and-hostcall.ll
  llvm/test/CodeGen/AMDGPU/opencl-printf.ll
  llvm/test/CodeGen/AMDGPU/propagate-attributes-function-pointer-argument.ll
  llvm/test/CodeGen/AMDGPU/r600.alu-limits.ll
  llvm/test/CodeGen/AMDGPU/reqd-work-group-size.ll
  llvm/test/CodeGen/AMDGPU/simplify-libcalls2.ll
  llvm/test/CodeGen/AMDGPU/speculative-execution-freecasts.ll
  llvm/test/CodeGen/AMDGPU/stress-calls.ll
  llvm/test/CodeGen/AMDGPU/tti-unroll-prefs.ll
  llvm/test/CodeGen/AMDGPU/unify-metadata.ll
  llvm/test/CodeGen/AMDGPU/vectorize-buffer-fat-pointer.ll
  llvm/test/CodeGen/ARM/bit-reverse-to-rbit.ll
  llvm/test/CodeGen/Generic/overloaded-intrinsic-name.ll
  llvm/test/CodeGen/NVPTX/access-non-generic.ll
  llvm/test/CodeGen/NVPTX/intrinsic-old.ll
  llvm/test/CodeGen/NVPTX/math-intrins-sm80-ptx70-instcombine.ll
  llvm/test/CodeGen/NVPTX/nvvm-reflect-module-flag.ll
  llvm/test/CodeGen/NVPTX/speculative-execution-divergent-target.ll
  llvm/test/CodeGen/PowerPC/ppc64-P9-mod.ll
  llvm/test/CodeGen/PowerPC/vec_shuffle.ll
  llvm/test/CodeGen/PowerPC/vperm-instcombine.ll
  llvm/test/CodeGen/SystemZ/inline-thresh-adjust.ll
  llvm/test/CodeGen/Thumb/consthoist-few-dependents.ll
  llvm/test/CodeGen/Thumb2/mve-intrinsics/predicates.ll
  llvm/test/CodeGen/Thumb2/mve-intrinsics/vadc-multiple.ll
  llvm/test/CodeGen/Thumb2/mve-vpt-from-intrinsics.ll
  llvm/test/CodeGen/WinEH/wineh-intrinsics.ll
  llvm/test/CodeGen/X86/GC/deadargelim.ll
  llvm/test/CodeGen/X86/GC/inline.ll
  llvm/test/CodeGen/X86/GC/inline2.ll
  llvm/test/CodeGen/X86/block-placement.ll
  llvm/test/CodeGen/X86/constant-hoisting-bfi.ll
  llvm/test/CodeGen/X86/deopt-intrinsic-cconv.ll
  llvm/test/CodeGen/X86/frame-order.ll
  llvm/test/CodeGen/X86/loadStore_vectorizer.ll
  llvm/test/CodeGen/X86/masked_gather_scatter.ll
  llvm/test/CodeGen/X86/no-plt-libcalls.ll
  llvm/test/CodeGen/X86/pointer-vector.ll
  llvm/test/CodeGen/X86/pr38762.ll
  llvm/test/CodeGen/X86/pr38763.ll
  llvm/test/CodeGen/X86/pr39243.ll
  llvm/test/CodeGen/X86/tls-loads-control2.ll
  llvm/test/CodeGen/X86/vector-gep.ll
  llvm/test/DebugInfo/AArch64/ir-outliner.ll
  llvm/test/DebugInfo/ARM/lowerbdgdeclare_vla.ll
  llvm/test/DebugInfo/Generic/2010-03-19-DbgDeclare.ll
  llvm/test/DebugInfo/Generic/PR37395.ll
  llvm/test/DebugInfo/Generic/assignment-tracking/dse/dse-after-memcpyopt-merge.ll
  llvm/test/DebugInfo/Generic/assignment-tracking/dse/shorten.ll
  llvm/test/DebugInfo/Generic/assignment-tracking/licm/merge.ll
  llvm/test/DebugInfo/Generic/assignment-tracking/licm/multi-exit.ll
  llvm/test/DebugInfo/Generic/assignment-tracking/memcpyopt/merge-stores.ll
  llvm/test/DebugInfo/Generic/assignment-tracking/parse-and-verify/instruction-type.ll
  llvm/test/DebugInfo/Generic/assignment-tracking/parse-and-verify/roundtrip.ll
  llvm/test/DebugInfo/Generic/assignment-tracking/parse-and-verify/verify.ll
  llvm/test/DebugInfo/Generic/callsite-attr-invalid.ll
  llvm/test/DebugInfo/Generic/debug-info-always-inline.ll
  llvm/test/DebugInfo/Generic/debug_value_list.ll
  llvm/test/DebugInfo/Generic/global-sra-array.ll
  llvm/test/DebugInfo/Generic/global-sra-single-member.ll
  llvm/test/DebugInfo/Generic/global-sra-struct-fwd-decl.ll
  llvm/test/DebugInfo/Generic/global-sra-struct-zero-length.ll
  llvm/test/DebugInfo/Generic/global-sra-struct.ll
  llvm/test/DebugInfo/Generic/indvar-discriminator.ll
  llvm/test/DebugInfo/Generic/inline-debug-info-multiret.ll
  llvm/test/DebugInfo/Generic/inline-debug-info.ll
  llvm/test/DebugInfo/Generic/inline-debug-loc.ll
  llvm/test/DebugInfo/Generic/inline-no-debug-info.ll
  llvm/test/DebugInfo/Generic/licm-hoist-debug-loc.ll
  llvm/test/DebugInfo/Generic/licm-hoist-intrinsic-debug-loc.ll
  llvm/test/DebugInfo/Generic/simplifycfg_sink_last_inst.ll
  llvm/test/DebugInfo/Generic/volatile-alloca.ll
  llvm/test/DebugInfo/X86/clone-module-2.ll
  llvm/test/DebugInfo/X86/clone-module.ll
  llvm/test/DebugInfo/X86/dbg-value-dropped-instcombine.ll
  llvm/test/DebugInfo/X86/dbgloc-insert-extract-val-instrs.ll
  llvm/test/DebugInfo/X86/dead-store-elimination-marks-undef.ll
  llvm/test/DebugInfo/X86/global-sra-fp80-array.ll
  llvm/test/DebugInfo/X86/global-sra-fp80-struct.ll
  llvm/test/DebugInfo/X86/global-sra-struct-fit-segment.ll
  llvm/test/DebugInfo/X86/instcombine-demanded-bits-salvage.ll
  llvm/test/DebugInfo/X86/licm-undef-dbg-value.ll
  llvm/test/DebugInfo/X86/undef-type-md.ll
  llvm/test/DebugInfo/check-debugify-preserves-analyses.ll
  llvm/test/DebugInfo/debugify-bogus-dbg-value.ll
  llvm/test/DebugInfo/debugify-export.ll
  llvm/test/DebugInfo/debugify-ignore-phi.ll
  llvm/test/DebugInfo/debugify-original-no-dbg-info.ll
  llvm/test/DebugInfo/debugify-report-missing-locs-only.ll
  llvm/test/DebugInfo/debugify.ll
  llvm/test/DebugInfo/duplicate_dbgvalue.ll
  llvm/test/DebugInfo/limit-arglist-size.ll
  llvm/test/DebugInfo/pr34672.ll
  llvm/test/DebugInfo/return-same-line-merge.ll
  llvm/test/DebugInfo/salvage-duplicate-values.ll
  llvm/test/DebugInfo/salvage-gep.ll
  llvm/test/DebugInfo/salvage-limit-expr-size.ll
  llvm/test/DebugInfo/salvage-nonconst-binop.ll
  llvm/test/DebugInfo/simplify-cfg-preserve-dbg-values.ll
  llvm/test/DebugInfo/unrolled-loop-remainder.ll
  llvm/test/DebugInfo/verify-di-preserve.ll
  llvm/test/Feature/OperandBundles/inliner-conservative.ll
  llvm/test/Feature/OperandBundles/inliner-funclet-wineh.ll
  llvm/test/Feature/OperandBundles/merge-func.ll
  llvm/test/Feature/global_pv.ll
  llvm/test/LTO/X86/keep-used-puts-during-instcombine.ll
  llvm/test/Other/2002-02-24-InlineBrokePHINodes.ll
  llvm/test/Other/2007-09-10-PassManager.ll
  llvm/test/Other/2008-02-14-PassManager.ll
  llvm/test/Other/2008-06-04-FieldSizeInPacked.ll
  llvm/test/Other/2008-10-06-RemoveDeadPass.ll
  llvm/test/Other/2009-06-05-no-implicit-float.ll
  llvm/test/Other/X86/debugcounter-divrempairs.ll
  llvm/test/Other/X86/debugcounter-partiallyinlinelibcalls.ll
  llvm/test/Other/cfg-printer-branch-weights-percent.ll
  llvm/test/Other/cfg-printer-branch-weights.ll
  llvm/test/Other/cfg-printer-filter.ll
  llvm/test/Other/cfg_deopt_unreach.ll
  llvm/test/Other/constant-fold-gep.ll
  llvm/test/Other/copy-metadata-of-declaration.ll
  llvm/test/Other/debugcounter-dce.ll
  llvm/test/Other/debugcounter-newgvn.ll
  llvm/test/Other/heat-colors-graphs.ll
  llvm/test/Other/heat-colors-multigraph.ll
  llvm/test/Other/module-pass-printer.ll
  llvm/test/Other/opt-legacy-syntax-deprecation.ll
  llvm/test/Other/optimization-remarks-inline.ll
  llvm/test/Other/pr32085.ll
  llvm/test/Other/print-debug-counter.ll
  llvm/test/Other/scalable-vector-struct-intrinsic.ll
  llvm/test/Other/scalable-vectors-core-ir.ll
  llvm/test/Transforms/HardwareLoops/ARM/structure.ll
  llvm/test/Transforms/LoadStoreVectorizer/X86/codegenprepare-produced-address-math.ll
  llvm/test/Verifier/dbg-invalid-vector.ll
  llvm/test/Verifier/di-subroutine-localvar.ll
  llvm/test/Verifier/fp-intrinsics.ll
  llvm/test/Verifier/non-integral-pointers.ll
  llvm/test/Verifier/preallocated-valid.ll
  llvm/test/Verifier/recursive-struct-param.ll
  llvm/test/Verifier/statepoint.ll
  llvm/test/Verifier/swifttailcc-musttail-valid.ll
  llvm/test/Verifier/tbaa.ll
  llvm/test/Verifier/vp-intrinsics.ll
  llvm/test/Verifier/weak-dllimport.ll
  llvm/test/tools/UpdateTestChecks/update_analyze_test_checks/Inputs/x86-loopvectorize-costmodel.ll
  llvm/test/tools/UpdateTestChecks/update_analyze_test_checks/Inputs/x86-loopvectorize-costmodel.ll.expected
  llvm/test/tools/llvm-reduce/remove-function-bodies-comdat.ll
  llvm/tools/opt/opt.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D139647.481340.patch
Type: text/x-patch
Size: 148133 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20221208/4206c927/attachment-0001.bin>