[PATCH] D139601: [LoopDistribute] Clear cache of `LoopAccessInfoManager`
Miguel Saldivar via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Dec 8 09:18:20 PST 2022
Saldivarcher added inline comments.
================
Comment at: llvm/lib/Transforms/Scalar/LoopDistribute.cpp:995
Changed |= LDL.processLoop();
+ LAIs.clear();
}
----------------
fhahn wrote:
> We only need to clear if changes were made AFAICT
The assertion is still hit if we only clear when changes are made, I think it's because we insert the loop [[ https://github.com/llvm/llvm-project/blob/main/llvm/lib/Transforms/Scalar/LoopDistribute.cpp#L681 | here ]], then fail right after. So, there's still cached data when there are no changes made. Keep in mind that the LoopDistribute pass fails with all the loops, and all fail [[ https://github.com/llvm/llvm-project/blob/main/llvm/lib/Transforms/Scalar/LoopDistribute.cpp#L686 | here. ]]
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D139601/new/
https://reviews.llvm.org/D139601
More information about the llvm-commits
mailing list