[PATCH] D139639: Attributes: Add function getter to parse integer string attributes
Matt Arsenault via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Dec 8 08:43:01 PST 2022
arsenm created this revision.
arsenm added reviewers: jdoerfert, craig.topper, lebedev.ri, rnk, aeubanks.
Herald added subscribers: kosarev, foad, StephenFan, kerbowa, pengfei, kbarton, hiraditya, jvesely, nemanjai.
Herald added a project: All.
arsenm requested review of this revision.
Herald added a subscriber: wdng.
Herald added a project: LLVM.
The most common case for string attributes parses them as integers. We
don't have a convenient way to do this, and as a result we have
inconsistent missing attribute and invalid attribute handling
scattered around. We also have inconsistent radix usage to
getAsInteger; some places use the default 0 and others use base 10.
Update a few of the uses, but there are quite a lot of these.
https://reviews.llvm.org/D139639
Files:
llvm/include/llvm/CodeGen/StackProtector.h
llvm/include/llvm/IR/Function.h
llvm/lib/CodeGen/StackProtector.cpp
llvm/lib/CodeGen/XRayInstrumentation.cpp
llvm/lib/IR/Function.cpp
llvm/lib/Target/AArch64/AArch64FrameLowering.cpp
llvm/lib/Target/AMDGPU/AMDGPUSubtarget.cpp
llvm/lib/Target/AMDGPU/AMDGPUTargetTransformInfo.cpp
llvm/lib/Target/AMDGPU/SIFormMemoryClauses.cpp
llvm/lib/Target/AMDGPU/Utils/AMDGPUBaseInfo.cpp
llvm/lib/Target/ARM/ARMFrameLowering.cpp
llvm/lib/Target/PowerPC/PPCISelLowering.cpp
llvm/lib/Target/SystemZ/SystemZISelLowering.cpp
llvm/lib/Target/X86/X86DynAllocaExpander.cpp
llvm/lib/Target/X86/X86ISelLowering.cpp
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D139639.481293.patch
Type: text/x-patch
Size: 14840 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20221208/99498ec7/attachment.bin>
More information about the llvm-commits
mailing list